From: Shriram Rajagopalan <rshriram@cs.ubc.ca>
To: "Liu, Jinsong" <jinsong.liu@intel.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH] Fix save.py bug
Date: Mon, 16 May 2011 21:58:48 -0400 [thread overview]
Message-ID: <BANLkTinQ_y1W1SLW0UyyGYnLgRovj67P+Q@mail.gmail.com> (raw)
In-Reply-To: <BC00F5384FCFC9499AF06F92E8B78A9E207637309B@shsmsx502.ccr.corp.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 1746 bytes --]
On Fri, May 13, 2011 at 1:33 PM, Liu, Jinsong <jinsong.liu@intel.com> wrote:
> Ian Campbell wrote:
> > Adding Remus maintainer. You can consult the MAINTAINERS file at the
> > top level to fix this.
> >
> > On Fri, 2011-05-13 at 15:26 +0100, Liu, Jinsong wrote:
> >> I don't know python well, but when I compile at my platform, compile
> >> error as:
> >>
> >>
> >> =======================
> >> ...
> >> Parsing libxl.idl
> >> cmp: _libxl_paths.h.tmp: No such file or directory
> >> cmp: _libxl_paths.h: No such file or directory
> >> cmp: xen/util/path.py: No such file or directory
> >> Parsing
> >>
> >>
> >> /otc/source/vtd/xen-unstable/tools/python/../../tools/libxl/libxl.idl
> >> File "/usr/lib64/python2.4/site-packages/xen/remus/save.py", line
> >> 169 finally: ^
> >> SyntaxError: invalid syntax
> >> ...
> >>
> >> ======================
> >>
> >>
> >> This kind of compile error introduced from c/s 23195.
> >> This patch revert it.
> >
> > That seems rather extreme in the first instance.
> >
> > From a quick google It seems that python 2.4 did not properly support
> > the "try: ... except: ... finally: ... " syntax. It appears that as a
> > workaround one can do
> > try:
> > try:
> > ...
> > except:
> > ...
> > finally:
> > ...
> >
> > But I didn't try this myself.
> >
> > Ian.
>
> Shriram and Ian,
>
> I update the patch according to Ian's comments, as attached.
> Test result shows compiling OK now.
>
> Hi,
sorry for the delay but I was waiting for the xen side bug to get resolved
before testing your patch. It works properly in remus installation.
Acked-by: Shriram Rajagopalan <rshriram@cs.ubc.ca>
Thanks,
> Jinsong
[-- Attachment #1.2: Type: text/html, Size: 2669 bytes --]
[-- Attachment #2: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2011-05-17 1:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-13 14:26 [PATCH] Fix save.py bug Liu, Jinsong
2011-05-13 14:36 ` Ian Campbell
2011-05-13 17:33 ` Liu, Jinsong
2011-05-17 1:58 ` Shriram Rajagopalan [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-05-18 8:30 Liu, Jinsong
2011-05-18 13:00 ` Shriram Rajagopalan
2011-05-19 12:05 ` Liu, Jinsong
2011-05-20 16:54 ` Ian Jackson
2011-05-21 3:30 ` Liu, Jinsong
2011-05-21 11:29 ` Shriram Rajagopalan
2011-05-23 8:22 ` Liu, Jinsong
2011-05-24 15:13 ` Ian Jackson
2011-05-25 2:32 ` Liu, Jinsong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinQ_y1W1SLW0UyyGYnLgRovj67P+Q@mail.gmail.com \
--to=rshriram@cs.ubc.ca \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=jinsong.liu@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).