From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shriram Rajagopalan Subject: Re: [PATCH] Fix save.py bug Date: Mon, 16 May 2011 21:58:48 -0400 Message-ID: References: <1305297378.31488.132.camel@zakaz.uk.xensource.com> Reply-To: rshriram@cs.ubc.ca Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0580003346==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Liu, Jinsong" Cc: "xen-devel@lists.xensource.com" , Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org --===============0580003346== Content-Type: multipart/alternative; boundary=bcaec52d51d744a83d04a36f1f40 --bcaec52d51d744a83d04a36f1f40 Content-Type: text/plain; charset=ISO-8859-1 On Fri, May 13, 2011 at 1:33 PM, Liu, Jinsong wrote: > Ian Campbell wrote: > > Adding Remus maintainer. You can consult the MAINTAINERS file at the > > top level to fix this. > > > > On Fri, 2011-05-13 at 15:26 +0100, Liu, Jinsong wrote: > >> I don't know python well, but when I compile at my platform, compile > >> error as: > >> > >> > >> ======================= > >> ... > >> Parsing libxl.idl > >> cmp: _libxl_paths.h.tmp: No such file or directory > >> cmp: _libxl_paths.h: No such file or directory > >> cmp: xen/util/path.py: No such file or directory > >> Parsing > >> > >> > >> /otc/source/vtd/xen-unstable/tools/python/../../tools/libxl/libxl.idl > >> File "/usr/lib64/python2.4/site-packages/xen/remus/save.py", line > >> 169 finally: ^ > >> SyntaxError: invalid syntax > >> ... > >> > >> ====================== > >> > >> > >> This kind of compile error introduced from c/s 23195. > >> This patch revert it. > > > > That seems rather extreme in the first instance. > > > > From a quick google It seems that python 2.4 did not properly support > > the "try: ... except: ... finally: ... " syntax. It appears that as a > > workaround one can do > > try: > > try: > > ... > > except: > > ... > > finally: > > ... > > > > But I didn't try this myself. > > > > Ian. > > Shriram and Ian, > > I update the patch according to Ian's comments, as attached. > Test result shows compiling OK now. > > Hi, sorry for the delay but I was waiting for the xen side bug to get resolved before testing your patch. It works properly in remus installation. Acked-by: Shriram Rajagopalan Thanks, > Jinsong --bcaec52d51d744a83d04a36f1f40 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On Fri, May 13, 2011 at 1:33 PM, Liu, Jinsong <jinsong.liu@in= tel.com> wrote:
Ian Campbell wrote:
> Adding Remus maintainer. You can consult the MAINTAINERS file at the > top level to fix this.
>
> On Fri, 2011-05-13 at 15:26 +0100, Liu, Jinsong wrote:
>> I don't know python well, but when I compile at my platform, c= ompile
>> error as:
>>
>>
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D
>> ...
>> Parsing libxl.idl
>> cmp: _libxl_paths.h.tmp: No such file or directory
>> cmp: _libxl_paths.h: No such file or directory
>> cmp: xen/util/path.py: No such file or directory
>> Parsing
>>
>>
>> /otc/source/vtd/xen-unstable/tools/python/../../tools/libxl/libxl.= idl
>> File "/usr/lib64/python2.4/site-packages/xen/remus/save.py&qu= ot;, line
>> 169 =A0 =A0 finally: ^
>> SyntaxError: invalid syntax
>> ...
>>
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
>>
>>
>> This kind of compile error introduced from c/s 23195.
>> This patch revert it.
>
> That seems rather extreme in the first instance.
>
> From a quick google It seems that python 2.4 did not properly support<= br> > the "try: ... except: ... finally: ... " syntax. It appears = that as a
> workaround one can do
> =A0 =A0 =A0 try:
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 try:
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ...
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 except:
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ...
> =A0 =A0 =A0 finally:
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 ...
>
> But I didn't try this myself.
>
> Ian.

Shriram and Ian,

I update the patch according to Ian's comments, as attached.
Test result shows compiling OK now.

Hi,
sorry for the delay but I was waiting for the = xen side bug to get resolved
before testing your patch. It works properl= y in remus installation.

Acked-by: Shriram Rajagopalan <rshriram@cs.ubc.ca>

Thanks,
Jinsong

--bcaec52d51d744a83d04a36f1f40-- --===============0580003346== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============0580003346==--