From: Haitao Shan <maillists.shan@gmail.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Allen M Kay <allen.m.kay@intel.com>
Subject: Re: use of struct hvm_mirq_dpci_mapping.gmsi vs. HVM_IRQ_DPCI_*_MSI flags
Date: Thu, 28 Apr 2011 09:31:08 +0800 [thread overview]
Message-ID: <BANLkTindGhYqQx2tGfchhj3Q+1ukGYdH+g@mail.gmail.com> (raw)
In-Reply-To: <4DB7D72A020000780003E4C4@vpn.id2.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 846 bytes --]
>
>
> But clarification on the current (perhaps vs intended) use of
> HVM_IRQ_DPCI_*_MSI would still be much appreciated (and if,
> as suspected, there's need to clean this up, I'd like the cleanup
> to be done before the patches I have pending).
>
> Jan, I think the meaning of the flags are pretty straight forward. But I
agree with you, we need to clean this up. I don't believe all the flags are
necessary at the moment (given the fact that they are introduced by
host-MSI-to-guest-INTx translation). But it is still OK for me if they did
not cause trouble and were not wrongly used.
I wonder whether the original patch has carefully considered the usage of
these flags when it tried to introduce these flags by nature.
Basically, I think it is up to you to decide their (flags) future. You are
already very careful on this. :)
Shan Haitao
[-- Attachment #1.2: Type: text/html, Size: 1161 bytes --]
[-- Attachment #2: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2011-04-28 1:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 14:15 use of struct hvm_mirq_dpci_mapping.gmsi vs. HVM_IRQ_DPCI_*_MSI flags Jan Beulich
2011-04-21 7:14 ` Haitao Shan
2011-04-26 8:48 ` Jan Beulich
2011-04-27 2:49 ` Kay, Allen M
2011-04-27 6:43 ` Jan Beulich
2011-04-28 1:31 ` Haitao Shan [this message]
2011-04-28 20:27 ` Kay, Allen M
2011-04-29 7:05 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTindGhYqQx2tGfchhj3Q+1ukGYdH+g@mail.gmail.com \
--to=maillists.shan@gmail.com \
--cc=JBeulich@novell.com \
--cc=allen.m.kay@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).