From: Wei Liu <liuw@liuw.name>
To: Takeshi HASEGAWA <hasegaw@gmail.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
Xen Devel <Xen-devel@lists.xensource.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] libxl: virtio-blk-pci support for FV domain
Date: Sun, 8 May 2011 13:24:53 +0800 [thread overview]
Message-ID: <BANLkTinow-MbvrAmHf7uck=ybS95RCiFBQ@mail.gmail.com> (raw)
In-Reply-To: <BANLkTimfyi1okskdUa=5CA0L=Ld-__QrGw@mail.gmail.com>
On Sun, May 8, 2011 at 12:56 PM, Wei Liu <liuw@liuw.name> wrote:
> Thanks, I just started working on VirtIO block support yesterday.
>
> I was trying to add support to parse_disk_config() so that we can
> specify "-if" option in the config file.
>
> I'm wondering which approach is better -- configure through
> device_virtdisk_matches() or parse_disk_config() .
>
> Any suggestions?
It seems that Takeshi's approach is better.
I should follow libxl's conventions.
--
Best regards
Wei Liu
Twitter: @iliuw
Site: http://liuw.name
next prev parent reply other threads:[~2011-05-08 5:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-08 3:48 [PATCH] libxl: virtio-blk-pci support for FV domain Takeshi HASEGAWA
2011-05-08 4:56 ` Wei Liu
2011-05-08 5:24 ` Wei Liu [this message]
2011-05-08 11:26 ` Takeshi HASEGAWA
2011-05-09 9:04 ` Ian Campbell
2011-05-09 14:44 ` Stefano Stabellini
2011-05-09 8:56 ` Ian Campbell
2011-05-09 9:01 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTinow-MbvrAmHf7uck=ybS95RCiFBQ@mail.gmail.com' \
--to=liuw@liuw.name \
--cc=Xen-devel@lists.xensource.com \
--cc=anthony.perard@citrix.com \
--cc=hasegaw@gmail.com \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).