From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <liuw@liuw.name>
Subject: Re: [PATCH] libxl: virtio-blk-pci support for FV domain
Date: Sun, 8 May 2011 13:24:53 +0800
Message-ID: <BANLkTinow-MbvrAmHf7uck=ybS95RCiFBQ@mail.gmail.com>
References: <BANLkTin2+FtCL4-L1ZsZUov2153HiXSq7w@mail.gmail.com>
	<BANLkTimfyi1okskdUa=5CA0L=Ld-__QrGw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <BANLkTimfyi1okskdUa=5CA0L=Ld-__QrGw@mail.gmail.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Takeshi HASEGAWA <hasegaw@gmail.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>, Xen Devel <Xen-devel@lists.xensource.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Sun, May 8, 2011 at 12:56 PM, Wei Liu <liuw@liuw.name> wrote:
> Thanks, I just started working on VirtIO block support yesterday.
>
> I was trying to add support to parse_disk_config() so that we can
> specify "-if" option in the config file.
>
> I'm wondering which approach is better -- configure through
> device_virtdisk_matches() or parse_disk_config() .
>
> Any suggestions?

It seems that Takeshi's approach is better.

I should follow libxl's conventions.

-- 
Best regards
Wei Liu
Twitter: @iliuw
Site: http://liuw.name