From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: cannot access memory beyond end of bootstrap
	direct-map area
Date: Thu, 27 Aug 2009 19:55:17 +0100
Message-ID: <C6BC9525.132DF%keir.fraser@eu.citrix.com>
References: <20090827172817.GA25165@bar>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20090827172817.GA25165@bar>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Pascal Bouchareine <pascal@gandi.net>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 27/08/2009 18:28, "Pascal Bouchareine" <pascal@gandi.net> wrote:

> Investigating the above message during xen 3.3 boot, found we left
> a wrong assumption [modules_length == (mod[n].end - mod[0].start)]
> in move_memory call, leading to an access above BOOTSTRAP_DIRECTMAP_END
> and this panic on x86_32.
> 
> In my understanding Keir's patch 18630 was fixing this kind of problem
> and I'm wondering why this move_memory call didn't go away with it ?

Looks like a backporting mistake. The original bug didn't happen on my
system so the bad backport wasn't noticed.

> If this were ok, attached patch fixes the panic on my system.

You should be able to remove the bogus move_memory() call, and change
absolutely nothing else. Does that also work for you? That's the change I
would check in.

 -- Keir