From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: build fixes
Date: Tue, 12 Jan 2010 17:38:18 +0000
Message-ID: <C772640A.6287%keir.fraser@eu.citrix.com>
References: <19276.44985.149108.19729@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <19276.44985.149108.19729@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Jackson <Ian.Jackson@eu.citrix.com>, Christoph Egger <Christoph.Egger@amd.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 12/01/2010 17:22, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote:

>> -    seek_ret = lseek64(fd, i << PAGE_SHIFT, SEEK_SET);
>> +    seek_ret = lseek(fd, i << PAGE_SHIFT, SEEK_SET);
> 
> This is just wrong.  It will break on >2G files.

We build everything under tools/ with LFS support enabled, so off_t is 64
bits even in 32-bit environments. FYI The bits to enable LFS support are in
tools/Rules.mk.

 -- Keir