From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Christoph Egger <Christoph.Egger@amd.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH][TOOLS] blktap: make memshr optional
Date: Tue, 12 Jan 2010 17:41:54 +0000 [thread overview]
Message-ID: <C77264E2.6290%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <19276.45320.957868.768458@mariner.uk.xensource.com>
On 12/01/2010 17:27, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote:
> Christoph Egger writes ("[Xen-devel] [PATCH][TOOLS] blktap: make memshr
> optional"):
>> Attached patch makes memshr optional for blktap/blktap2.
>> This fixes build for platforms where memshr isn't build on.
>
> That and ...
>
>> While there, make indentation consistent.
>
> ... this should be separated out, surely.
>
> Mixing up a whitespace change with anything else is a recipe for
> making things hard to track down.
In this rare case it looked okay to me, as the whitespace changes are
exactly co-located with the patch's semantic changes. So the semantic
changes remain pretty clear in the diff.
-- Keir
prev parent reply other threads:[~2010-01-12 17:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 17:09 [PATCH][TOOLS] blktap: make memshr optional Christoph Egger
2010-01-12 17:27 ` Ian Jackson
2010-01-12 17:41 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C77264E2.6290%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=Christoph.Egger@amd.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).