From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH][TOOLS] blktap: make memshr optional
Date: Tue, 12 Jan 2010 17:41:54 +0000
Message-ID: <C77264E2.6290%keir.fraser@eu.citrix.com>
References: <19276.45320.957868.768458@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <19276.45320.957868.768458@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Jackson <Ian.Jackson@eu.citrix.com>, Christoph Egger <Christoph.Egger@amd.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 12/01/2010 17:27, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote:

> Christoph Egger writes ("[Xen-devel] [PATCH][TOOLS] blktap: make memshr
> optional"):
>> Attached patch makes memshr optional for blktap/blktap2.
>> This fixes build for platforms where memshr isn't build on.
> 
> That and ...
> 
>> While there, make indentation consistent.
> 
> ... this should be separated out, surely.
> 
> Mixing up a whitespace change with anything else is a recipe for
> making things hard to track down.

In this rare case it looked okay to me, as the whitespace changes are
exactly co-located with the patch's semantic changes. So the semantic
changes remain pretty clear in the diff.

 -- Keir