From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: build fixes
Date: Tue, 12 Jan 2010 18:44:04 +0000
Message-ID: <C7727374.62A6%keir.fraser@eu.citrix.com>
References: <4B4CB49A.90802@cs.ubc.ca>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4B4CB49A.90802@cs.ubc.ca>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Patrick Colp <pjcolp@cs.ubc.ca>
Cc: Christoph Egger <Christoph.Egger@amd.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 12/01/2010 17:42, "Patrick Colp" <pjcolp@cs.ubc.ca> wrote:

>> We build everything under tools/ with LFS support enabled, so off_t is 64
>> bits even in 32-bit environments. FYI The bits to enable LFS support are in
>> tools/Rules.mk.
> 
> According to the lseek64 man page, for 32-bit architectures to have 64-bit
> off_t, you need:
> 
> #define _FILE_OFFSET_BITS 64
> 
> Which, as far as I know, isn't set. LFS just makes lseek64 available
> (without it, the function doesn't exist).

I don't think so. 'getconf LFS_CFLAGS' returns -D_FILE_OFFSET_BITS=64 on a
32-bit host. It's LFS64_CFLAGS that gets you the explicit model for
large-file access (i.e., where you have to explicitly use the 64-bit off_t
and lseek variants).

 -- Keir