From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH, RFC 3/4] qemu: use new (replacement) mmap-batch ioctl Date: Wed, 13 Jan 2010 07:59:41 +0000 Message-ID: References: <4B4D893A02000078000299B5@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4B4D893A02000078000299B5@vpn.id2.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich , Ian Jackson Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 13/01/2010 07:50, "Jan Beulich" wrote: >> This should be done by using the #ifdef arround the call to >> xc_map_foreign_bulk, not by having a weak symbol compared to NULL. > > While indeed I wasn't sure about how (or if at all) to put in > backward compatibility, this seemed to be the consolidated place. > > Using and #ifdef in the source file doesn't seem nice though, as it > would tie a qemu built against older headers to using the old > interface. But since I'm not sure about the compatibility needs in > the first place, I will listen to whatever you say you deem > appropriate. Qemu is deemed part of the tollstack matched set, so compatibility with older libxc is not an issue. The primary concern is to provide continued compatibility with older dom0 kernels, which I believe you entirely handle within libxc. -- Keir