From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Andre Przywara <andre.przywara@amd.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] numa: fix problems with memory-less nodes
Date: Wed, 13 Jan 2010 09:55:59 +0000 [thread overview]
Message-ID: <C773492F.63FB%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <4B4D9582.5010806@amd.com>
On 13/01/2010 09:42, "Andre Przywara" <andre.przywara@amd.com> wrote:
> To be honest I am not a fan of omitting nodes from physinfo, but that is
> what the current code (RC1!) does and it definitely breaks Xen on my
> box. So I just made this small patch to make it work again.
> Actually I would opt to revert the patch cropping the number of nodes
> reported by physinfo (20762:a1d0a575b4ba ?). Yes, that would result in
> nodes reported with zero memory, but in my tests this did not raise
> problems, as a node's memory can (and will) be exhausted even during
> normal operation.
The intention of 20762 was not to change the semantics of the node_to_*
lists. It's simply supposed to make available max_node_id to the toolstack
(since this can differ from nr_nodes if there are holes in the online node
map).
If the node_to_* semantics really have been changed by 20762, then it is a
bug. It's not a bug I can eyeball however.
-- Keir
next prev parent reply other threads:[~2010-01-13 9:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 16:30 [PATCH] numa: fix problems with memory-less nodes Andre Przywara
2010-01-13 8:26 ` Keir Fraser
2010-01-13 9:42 ` Andre Przywara
2010-01-13 9:55 ` Keir Fraser [this message]
2010-01-13 10:02 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C773492F.63FB%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=andre.przywara@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).