From: Keir Fraser <keir.fraser@eu.citrix.com>
To: "Cui, Dexuan" <dexuan.cui@intel.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] x86: check if desc->action is NULL when unbinding guest pirq
Date: Tue, 26 Jan 2010 15:57:29 +0000 [thread overview]
Message-ID: <C784C169.7772%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <ED3036A092A28F4C91B0B4360DD128EA35C4D5A1@shzsmsx502.ccr.corp.intel.com>
On 22/01/2010 08:01, "Cui, Dexuan" <dexuan.cui@intel.com> wrote:
> Before igb PF driver is unloaded, dom0 doesn't unload igbvf driver
> automatically. When igb drver is unloaded, it invokes the
> PHYSDEVOP_manage_pci_remove hypercall to remove the VFs and xen frees the msi
> irqs by pci_cleanup_msi() -> ... -> dynamic_irq_cleanup() and sets the
> desc->action to NULL.
> igbvf driver knows the VF is disappearing via a hook ndo_stop() in dev_close()
> and tries to unbind the pirq and xen would crash as the desc->action
> is NULL now.
> The patch adds the checking for this.
Although I checked this in as c/s 20844, I now wonder what the
'desc->status|IRQ_DISABLED' is included for? (e.g., see below extract:)
+ if (unlikely((desc->status | IRQ_DISABLED) && (desc->action == NULL)))
Looks pointless: should this just be 'if(desc->action==NULL)'?
-- Keir
next prev parent reply other threads:[~2010-01-26 15:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 8:01 [PATCH] x86: check if desc->action is NULL when unbinding guest pirq Cui, Dexuan
2010-01-26 15:57 ` Keir Fraser [this message]
2010-01-29 2:55 ` Cui, Dexuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C784C169.7772%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=dexuan.cui@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).