[PATCH] svm: Fix migration in the middle of a syscall

[PATCH] svm: Fix migration in the middle of a syscall

[Christoph Egger]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]


Hi!

Attached patch fixes migration in the middle of a syscall.

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>

Keir: Please also apply this patch to xen-3.4-testing.


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

[-- Attachment #2: xen_vmcb_kerngsbase.diff --]
[-- Type: text/x-diff, Size: 825 bytes --]

diff -r c6f0968fdfe2 xen/arch/x86/hvm/svm/svm.c
--- a/xen/arch/x86/hvm/svm/svm.c	Mon Jan 25 14:34:36 2010 +0100
+++ b/xen/arch/x86/hvm/svm/svm.c	Wed Jan 27 14:17:31 2010 +0100
@@ -192,6 +192,7 @@ static int svm_vmcb_save(struct vcpu *v,
     c->sysenter_cs = v->arch.hvm_svm.guest_sysenter_cs;
     c->sysenter_esp = v->arch.hvm_svm.guest_sysenter_esp;
     c->sysenter_eip = v->arch.hvm_svm.guest_sysenter_eip;
+    c->shadow_gs = vmcb->kerngsbase;
 
     c->pending_event = 0;
     c->error_code = 0;
@@ -251,6 +252,7 @@ static int svm_vmcb_restore(struct vcpu 
     v->arch.hvm_svm.guest_sysenter_cs = c->sysenter_cs;
     v->arch.hvm_svm.guest_sysenter_esp = c->sysenter_esp;
     v->arch.hvm_svm.guest_sysenter_eip = c->sysenter_eip;
+    vmcb->kerngsbase = c->shadow_gs;
 
     if ( paging_mode_hap(v->domain) )
     {

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] svm: Fix migration in the middle of a syscall

[Keir Fraser]

Looks like this is already handled in svm_{save,load}_cpu_state(). Did you
actually reproduce this bug?

 -- Keir

On 27/01/2010 13:17, "Christoph Egger" <Christoph.Egger@amd.com> wrote:

> 
> Hi!
> 
> Attached patch fixes migration in the middle of a syscall.
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
> 
> Keir: Please also apply this patch to xen-3.4-testing.
>