xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Keir Fraser <keir.fraser@eu.citrix.com>
To: "Wang, Shane" <shane.wang@intel.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Cc: "Cihula, Joseph" <joseph.cihula@intel.com>,
	"Hao, Xudong" <xudong.hao@intel.com>
Subject: Re: Xenheap issue on 32b
Date: Thu, 28 Jan 2010 18:47:05 +0000	[thread overview]
Message-ID: <C7878C29.7C12%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <6CADD16F56BC954D8E28F3836FA7ED71179323EE71@shzsmsx501.ccr.corp.intel.com>

In init_Xenheap_pages(), try placing the call to memguard_guard_range()
*after* the adjustments to ps and pe (i.e., immediately before the call to
init_heap_pages()). I reckon that simple change should work for you.

 -- Keir

On 28/01/2010 15:29, "Wang, Shane" <shane.wang@intel.com> wrote:

> Hi Keir,
> 
> The issue causes page fault when the MACing code tries to access the page and
> hang.
> I suggest to initialize that page (I think it is in use because of dirty
> content) as unused, or xenheap_phys_end minus one page.
> 
> Which one do you prefer?
> 
> Thanks.
> Shane
> 
> Wang, Shane wrote:
>> 
>> OK, now the page 0xbff000 is xenheap according to is_xen_heap_page(),
>> and it is used according to is_page_in_use(), but it is not mapped.
>> The issue happens.
>> 
>> Comment?
>> 
>> Thanks.
>> Shane
> 
> 

      reply	other threads:[~2010-01-28 18:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-28 15:13 Xenheap issue on 32b Wang, Shane
2010-01-28 15:29 ` Wang, Shane
2010-01-28 18:47   ` Keir Fraser [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C7878C29.7C12%keir.fraser@eu.citrix.com \
    --to=keir.fraser@eu.citrix.com \
    --cc=joseph.cihula@intel.com \
    --cc=shane.wang@intel.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=xudong.hao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).