Re: [PATCH 0 of 4] aio event fd support to blktap2

[Keir Fraser <keir.fraser@eu.citrix.com>]

On 29/01/2010 08:45, "Daniel Stodden" <daniel.stodden@citrix.com> wrote:

> On Fri, 2010-01-29 at 03:29 -0500, Daniel Stodden wrote:
>> On Fri, 2010-01-29 at 03:09 -0500, Keir Fraser wrote:
>>> Echo the changeset comment and sign-off into the email body would be better,
>>> but your re-send is fine as far as I'm concerned. I should be able to apply
>>> the attachments no problem.
>> 
>> Patchbomb as of hg 1.3.1 doesn't seem to do this.
> 
> Ah, it does.
> 
> So --inline implies --attach,
> but is still different from --inline *and* --attach.
> 
> Sorry for the noise.

By the way, attaching and inlining a whole patch is also acceptable. Some
people like inline patches, so that they can easily review and comment. I
like attachments because they JustWork when I'm trying to apply big bundles
of patches.

For smaller patches, inline only can be okay. For some reason, I find that
inline large patches rarely apply for me. It's really weird, given I only
fetchmail and munpack the emails, and yet I have a suspicion the mangling
does happen at my end.

 -- Keir