From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] HVM vcpu hotplug: Fix acpi method NTFY bug Date: Sun, 31 Jan 2010 17:06:47 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Liu, Jinsong" , xen-devel Cc: "Zheng, Shaohui" , "Ke, Liping" , "Jiang, Yunhong" List-Id: xen-devel@lists.xenproject.org On 31/01/2010 14:04, "Liu, Jinsong" wrote: > According to your suggestion, I plan to modify the patch as: > 1. cancel method NTFY, merge it into method PRSC; > 2. at method PRSC, only scan 'maxvcpus' times. we can transfer 'maxvcpus' > (which comes from cmdline) from qemu to dsdt side through bios_info; > 3. at mk_dsdt.c, add some comments to make it clear; > Do you think it OK? I don't even mind if you don't do #2. That's up to you. Bear in mind that to be able to merge NTFY into PRSC, you will have to completely unroll PRSC (one way to view it is moving the loops out of the DSDT and into mk_dsdt.c, to be executed at build time and produce straight-line code). That would mean you emit the code to check against max_vcpus 128 times. Is it worth it? I don't know. -- Keir