From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] HVM vcpu hotplug: Fix acpi method NTFY bug Date: Mon, 01 Feb 2010 12:40:09 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="B_3347872816_36176136" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Liu, Jinsong" , xen-devel Cc: "Zheng, Shaohui" , "Ke, Liping" , "Jiang, Yunhong" List-Id: xen-devel@lists.xenproject.org > This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. --B_3347872816_36176136 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit On 01/02/2010 11:21, "Liu, Jinsong" wrote: > 5. a simple way to solve the issue is, to make sure scan loop of NTFY = scan > loop of PRSC, and to make sure NTFY always scan 2^n vcpus. > However, NTFY scan loop may change in the future, not necessary equal to > 2^n, and not necessary equal to scan loop of PRSC. That's the reason why I use > for() loop inside of decision_tree() in method NTFY at the patch I send Jan > 27. It will work correctly under whatever conditions, and keep mk_dsdt.c > easier to understand. Decision_tree indeed reduce scan greatly, but it's not > in key path. Ah, now I understand! Okay, how about the attached patch? This fixes the bug by inlining NTFY into PRSC, and also uses HVM_MAX_VCPUS as appropriate. Please take a look and also test it. I'll apply it if/when you Ack it. -- Keir --B_3347872816_36176136 Content-type: application/octet-stream; name="00-dsdt" Content-disposition: attachment; filename="00-dsdt" Content-transfer-encoding: base64 ZGlmZiAtciA4NTdkN2IyZGQ4YzcgdG9vbHMvZmlybXdhcmUvaHZtbG9hZGVyL2FjcGkvbWtf ZHNkdC5jCi0tLSBhL3Rvb2xzL2Zpcm13YXJlL2h2bWxvYWRlci9hY3BpL21rX2RzZHQuYwlG cmkgSmFuIDI5IDA4OjU5OjQ2IDIwMTAgKzAwMDAKKysrIGIvdG9vbHMvZmlybXdhcmUvaHZt bG9hZGVyL2FjcGkvbWtfZHNkdC5jCU1vbiBGZWIgMDEgMTI6Mzc6MTkgMjAxMCArMDAwMApA QCAtMSw1ICsxLDcgQEAKICNpbmNsdWRlIDxzdGRpby5oPgogI2luY2x1ZGUgPHN0ZGFyZy5o PgorI2luY2x1ZGUgPHN0ZGludC5oPgorI2luY2x1ZGUgPHhlbi9odm0vaHZtX2luZm9fdGFi bGUuaD4KIAogc3RhdGljIHVuc2lnbmVkIGludCBpbmRlbnRfbGV2ZWw7CiAKQEAgLTQ3LDIx ICs0OSw2IEBACiAgICAgcHJpbnRmKCJ9XG4iKTsKIH0KIAotc3RhdGljIHZvaWQgY3B1X2hv dHBsdWdfbm90aWZ5KHVuc2lnbmVkIGludCBjcHUpCi17Ci0gICAgcHVzaF9ibG9jaygiSWYi LCAiTE5vdEVxdWFsKEFyZzEsIFxcX1BSLlBSJTAyWC5GTEcpIiwgY3B1KTsKLSAgICBzdG10 KCJTdG9yZSIsICJBcmcxLCBcXF9QUi5QUiUwMlguRkxHIiwgY3B1KTsKLSAgICBwdXNoX2Js b2NrKCJJZiIsICJMRXF1YWwoQXJnMSwgMSkiKTsKLSAgICBzdG10KCJOb3RpZnkiLCAiUFIl MDJYLCAxIiwgY3B1KTsKLSAgICBzdG10KCJTdWJ0cmFjdCIsICJcXF9QUi5NU1UsIDEsIFxc X1BSLk1TVSIpOwotICAgIHBvcF9ibG9jaygpOwotICAgIHB1c2hfYmxvY2soIkVsc2UiLCBO VUxMKTsKLSAgICBzdG10KCJOb3RpZnkiLCAiUFIlMDJYLCAzIiwgY3B1KTsKLSAgICBzdG10 KCJBZGQiLCAiXFxfUFIuTVNVLCAxLCBcXF9QUi5NU1UiKTsKLSAgICBwb3BfYmxvY2soKTsK LSAgICBwb3BfYmxvY2soKTsKLX0KLQogc3RhdGljIHZvaWQgcGNpX2hvdHBsdWdfbm90aWZ5 KHVuc2lnbmVkIGludCBzbHQpCiB7CiAgICAgc3RtdCgiTm90aWZ5IiwgIlxcX1NCLlBDSTAu UyUwMlgsIEVWVCIsIHNsdCk7CkBAIC0xMDIsNyArODksNyBAQAogICAgIHBvcF9ibG9jaygp OwogCiAgICAgLyogRGVmaW5lIHByb2Nlc3NvciBvYmplY3RzIGFuZCBjb250cm9sIG1ldGhv ZHMuICovCi0gICAgZm9yICggY3B1ID0gMDsgY3B1IDwgMTI4OyBjcHUrKykKKyAgICBmb3Ig KCBjcHUgPSAwOyBjcHUgPCBIVk1fTUFYX1ZDUFVTOyBjcHUrKykKICAgICB7CiAgICAgICAg IHB1c2hfYmxvY2soIlByb2Nlc3NvciIsICJQUiUwMlgsICVkLCAweDAwMDBiMDEwLCAweDA2 IiwgY3B1LCBjcHUpOwogCkBAIC0xNDEsMzEgKzEyOCwzOCBAQAogICAgICAgICBwb3BfYmxv Y2soKTsKICAgICB9CiAKLSAgICAvKiBEZWZpbmUgY29udHJvbCBtZXRob2QgJ05URlknLiAq LwotICAgIHB1c2hfYmxvY2soIk1ldGhvZCIsICJOVEZZLCAyIik7Ci0gICAgZGVjaXNpb25f dHJlZSgwLCAxMjgsICJBcmcwIiwgY3B1X2hvdHBsdWdfbm90aWZ5KTsKLSAgICBzdG10KCJS ZXR1cm4iLCAiT25lIik7CisgICAgLyogT3BlcmF0aW9uIFJlZ2lvbiAnUFJTVCc6IGJpdG1h c2sgb2Ygb25saW5lIENQVXMuICovCisgICAgc3RtdCgiT3BlcmF0aW9uUmVnaW9uIiwgIlBS U1QsIFN5c3RlbUlPLCAweGFmMDAsIDMyIik7CisgICAgcHVzaF9ibG9jaygiRmllbGQiLCAi UFJTVCwgQnl0ZUFjYywgTm9Mb2NrLCBQcmVzZXJ2ZSIpOworICAgIGluZGVudCgpOyBwcmlu dGYoIlBSUywgJXVcbiIsIEhWTV9NQVhfVkNQVVMpOwogICAgIHBvcF9ibG9jaygpOwogCi0g ICAgLyogRGVmaW5lIGNvbnRyb2wgbWV0aG9kICdQUlNDJy4gKi8KLSAgICBzdG10KCJPcGVy YXRpb25SZWdpb24iLCAiUFJTVCwgU3lzdGVtSU8sIDB4YWYwMCwgMzIiKTsKLSAgICBwdXNo X2Jsb2NrKCJGaWVsZCIsICJQUlNULCBCeXRlQWNjLCBOb0xvY2ssIFByZXNlcnZlIik7Ci0g ICAgaW5kZW50KCk7IHByaW50ZigiUFJTLCAyNTZcbiIpOwotICAgIHBvcF9ibG9jaygpOwot CisgICAgLyogQ29udHJvbCBtZXRob2QgJ1BSU0MnOiBDUFUgaG90cGx1ZyBHUEUgaGFuZGxl ci4gKi8KICAgICBwdXNoX2Jsb2NrKCJNZXRob2QiLCAiUFJTQywgMCIpOwotICAgIHN0bXQo IlN0b3JlIiwgIlBSUywgTG9jYWwzIik7Ci0gICAgc3RtdCgiU3RvcmUiLCAiWmVybywgTG9j YWwwIik7Ci0gICAgcHVzaF9ibG9jaygiV2hpbGUiLCAiTExlc3MoTG9jYWwwLCAzMikiKTsK LSAgICBzdG10KCJTdG9yZSIsICJaZXJvLCBMb2NhbDEiKTsKLSAgICBzdG10KCJTdG9yZSIs ICJEZXJlZk9mKEluZGV4KExvY2FsMywgTG9jYWwwKSksIExvY2FsMiIpOwotICAgIHB1c2hf YmxvY2soIldoaWxlIiwgIkxMZXNzKExvY2FsMSwgOCkiKTsKLSAgICBzdG10KCJOVEZZIiwg IkFkZChNdWx0aXBseShMb2NhbDAsIDgpLCBMb2NhbDEpLCBBbmQoTG9jYWwyLCAxKSIpOwot ICAgIHN0bXQoIlNoaWZ0UmlnaHQiLCAiTG9jYWwyLCAxLCBMb2NhbDIiKTsKLSAgICBzdG10 KCJJbmNyZW1lbnQiLCAiTG9jYWwxIik7Ci0gICAgcG9wX2Jsb2NrKCk7Ci0gICAgc3RtdCgi SW5jcmVtZW50IiwgIkxvY2FsMCIpOwotICAgIHBvcF9ibG9jaygpOworICAgIHN0bXQoIlN0 b3JlIiwgIlBSUywgTG9jYWwwIik7CisgICAgZm9yICggY3B1ID0gMDsgY3B1IDwgSFZNX01B WF9WQ1BVUzsgY3B1KysgKQorICAgIHsKKyAgICAgICAgLyogUmVhZCBhIGJ5dGUgYXQgYSB0 aW1lIGZyb20gdGhlIFBSU1Qgb25saW5lLUNQVSBiaXRtYXNrLiAqLworICAgICAgICBpZiAo IChjcHUgJiA3KSA9PSAwICkKKyAgICAgICAgICAgIHN0bXQoIlN0b3JlIiwgIkRlcmVmT2Yo SW5kZXgoTG9jYWwwLCAldSkpLCBMb2NhbDEiLCBjcHUvOCk7CisgICAgICAgIGVsc2UKKyAg ICAgICAgICAgIHN0bXQoIlNoaWZ0UmlnaHQiLCAiTG9jYWwxLCAxLCBMb2NhbDEiKTsKKyAg ICAgICAgLyogRXh0cmFjdCBjdXJyZW50IENQVSdzIHN0YXR1czogMD1vZmZsaW5lOyAxPW9u bGluZS4gKi8KKyAgICAgICAgc3RtdCgiQW5kIiwgIkxvY2FsMSwgMSwgTG9jYWwyIik7Cisg ICAgICAgIC8qIENoZWNrIGlmIHN0YXR1cyBpcyB1cC10by1kYXRlIGluIHRoZSByZWxldmFu dCBNQURUIExBUElDIGVudHJ5Li4uICovCisgICAgICAgIHB1c2hfYmxvY2soIklmIiwgIkxO b3RFcXVhbChMb2NhbDIsIFxcX1BSLlBSJTAyWC5GTEcpIiwgY3B1KTsKKyAgICAgICAgLyog Li4uSWYgbm90LCB1cGRhdGUgaXQgYW5kIHRoZSBNQURUIGNoZWNrc3VtLCBhbmQgbm90aWZ5 IE9TUE0uICovCisgICAgICAgIHN0bXQoIlN0b3JlIiwgIkxvY2FsMiwgXFxfUFIuUFIlMDJY LkZMRyIsIGNwdSk7CisgICAgICAgIHB1c2hfYmxvY2soIklmIiwgIkxFcXVhbChMb2NhbDIs IDEpIik7CisgICAgICAgIHN0bXQoIk5vdGlmeSIsICJQUiUwMlgsIDEiLCBjcHUpOyAvKiBO b3RpZnk6IERldmljZSBDaGVjayAqLworICAgICAgICBzdG10KCJTdWJ0cmFjdCIsICJcXF9Q Ui5NU1UsIDEsIFxcX1BSLk1TVSIpOyAvKiBBZGp1c3QgTUFEVCBjc3VtICovCisgICAgICAg IHBvcF9ibG9jaygpOworICAgICAgICBwdXNoX2Jsb2NrKCJFbHNlIiwgTlVMTCk7CisgICAg ICAgIHN0bXQoIk5vdGlmeSIsICJQUiUwMlgsIDMiLCBjcHUpOyAvKiBOb3RpZnk6IEVqZWN0 IFJlcXVlc3QgKi8KKyAgICAgICAgc3RtdCgiQWRkIiwgIlxcX1BSLk1TVSwgMSwgXFxfUFIu TVNVIik7IC8qIEFkanVzdCBNQURUIGNzdW0gKi8KKyAgICAgICAgcG9wX2Jsb2NrKCk7Cisg ICAgICAgIHBvcF9ibG9jaygpOworICAgIH0KICAgICBzdG10KCJSZXR1cm4iLCAiT25lIik7 CiAgICAgcG9wX2Jsb2NrKCk7CiAK --B_3347872816_36176136 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --B_3347872816_36176136--