From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: RE: [PATCH 1/2] Vcpu hotplug: Move ACPI processor from \_PR to \_SB Date: Fri, 12 Feb 2010 10:29:20 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="B_3348815367_8355688" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Liu, Jinsong" , "Jiang, Yunhong" , xen-devel List-Id: xen-devel@lists.xenproject.org > This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. --B_3348815367_8355688 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit On 12/02/2010 10:07, "Liu, Jinsong" wrote: >> Win2k8 has a similar problem? >> >> -- Keir > > Yes. Yunhong test Win2k8, and found in Win2k8 data center version, cpu hotplug > successed for _SB definition, but failed for _PR definition. (success mean, > after we hot-add vcpu, the device manager will shown new processor, but the > task manager has no changes, same as > http://www.boche.net/blog/index.php/2009/05/10/vsphere-memory-hot-add-cpu-hot- > plug/ .Fail mean even the device manager has no changes). Okay, how about the attached alternative patch then? Smaller than yours but hoepfully equivalent. It doesn't include your change to the _STA method to return 0 instead of 9 in the offline case however -- there was no explanation for that in the changeset comment? -- Keir --B_3348815367_8355688 Content-type: application/octet-stream; name="00-dsdt" Content-disposition: attachment; filename="00-dsdt" Content-transfer-encoding: base64 ZGlmZiAtciAzYmIxNjNiNzQ2NzMgdG9vbHMvZmlybXdhcmUvaHZtbG9hZGVyL2FjcGkvbWtf ZHNkdC5jCi0tLSBhL3Rvb2xzL2Zpcm13YXJlL2h2bWxvYWRlci9hY3BpL21rX2RzZHQuYwlG cmkgRmViIDEyIDA5OjI0OjE4IDIwMTAgKzAwMDAKKysrIGIvdG9vbHMvZmlybXdhcmUvaHZt bG9hZGVyL2FjcGkvbWtfZHNkdC5jCUZyaSBGZWIgMTIgMTA6Mjc6NDcgMjAxMCArMDAwMApA QCAtODMsNyArODMsNyBAQAogICAgIGluZGVudF9sZXZlbCsrOwogCiAgICAgLyoqKiogUHJv Y2Vzc29yIHN0YXJ0ICoqKiovCi0gICAgcHVzaF9ibG9jaygiU2NvcGUiLCAiXFxfUFIiKTsK KyAgICBwdXNoX2Jsb2NrKCJTY29wZSIsICJcXF9TQiIpOwogCiAgICAgLyogTUFEVCBjaGVj a3N1bSAqLwogICAgIHN0bXQoIk9wZXJhdGlvblJlZ2lvbiIsICJNU1VNLCBTeXN0ZW1NZW1v cnksIFxcX1NCLk1TVUEsIDEiKTsKQEAgLTE1MCwxNiArMTUwLDE2IEBACiAgICAgICAgIC8q IEV4dHJhY3QgY3VycmVudCBDUFUncyBzdGF0dXM6IDA9b2ZmbGluZTsgMT1vbmxpbmUuICov CiAgICAgICAgIHN0bXQoIkFuZCIsICJMb2NhbDEsIDEsIExvY2FsMiIpOwogICAgICAgICAv KiBDaGVjayBpZiBzdGF0dXMgaXMgdXAtdG8tZGF0ZSBpbiB0aGUgcmVsZXZhbnQgTUFEVCBM QVBJQyBlbnRyeS4uLiAqLwotICAgICAgICBwdXNoX2Jsb2NrKCJJZiIsICJMTm90RXF1YWwo TG9jYWwyLCBcXF9QUi5QUiUwMlguRkxHKSIsIGNwdSk7CisgICAgICAgIHB1c2hfYmxvY2so IklmIiwgIkxOb3RFcXVhbChMb2NhbDIsIFxcX1NCLlBSJTAyWC5GTEcpIiwgY3B1KTsKICAg ICAgICAgLyogLi4uSWYgbm90LCB1cGRhdGUgaXQgYW5kIHRoZSBNQURUIGNoZWNrc3VtLCBh bmQgbm90aWZ5IE9TUE0uICovCi0gICAgICAgIHN0bXQoIlN0b3JlIiwgIkxvY2FsMiwgXFxf UFIuUFIlMDJYLkZMRyIsIGNwdSk7CisgICAgICAgIHN0bXQoIlN0b3JlIiwgIkxvY2FsMiwg XFxfU0IuUFIlMDJYLkZMRyIsIGNwdSk7CiAgICAgICAgIHB1c2hfYmxvY2soIklmIiwgIkxF cXVhbChMb2NhbDIsIDEpIik7CiAgICAgICAgIHN0bXQoIk5vdGlmeSIsICJQUiUwMlgsIDEi LCBjcHUpOyAvKiBOb3RpZnk6IERldmljZSBDaGVjayAqLwotICAgICAgICBzdG10KCJTdWJ0 cmFjdCIsICJcXF9QUi5NU1UsIDEsIFxcX1BSLk1TVSIpOyAvKiBBZGp1c3QgTUFEVCBjc3Vt ICovCisgICAgICAgIHN0bXQoIlN1YnRyYWN0IiwgIlxcX1NCLk1TVSwgMSwgXFxfU0IuTVNV Iik7IC8qIEFkanVzdCBNQURUIGNzdW0gKi8KICAgICAgICAgcG9wX2Jsb2NrKCk7CiAgICAg ICAgIHB1c2hfYmxvY2soIkVsc2UiLCBOVUxMKTsKICAgICAgICAgc3RtdCgiTm90aWZ5Iiwg IlBSJTAyWCwgMyIsIGNwdSk7IC8qIE5vdGlmeTogRWplY3QgUmVxdWVzdCAqLwotICAgICAg ICBzdG10KCJBZGQiLCAiXFxfUFIuTVNVLCAxLCBcXF9QUi5NU1UiKTsgLyogQWRqdXN0IE1B RFQgY3N1bSAqLworICAgICAgICBzdG10KCJBZGQiLCAiXFxfU0IuTVNVLCAxLCBcXF9TQi5N U1UiKTsgLyogQWRqdXN0IE1BRFQgY3N1bSAqLwogICAgICAgICBwb3BfYmxvY2soKTsKICAg ICAgICAgcG9wX2Jsb2NrKCk7CiAgICAgfQpAQCAtMTcxLDcgKzE3MSw3IEBACiAgICAgLyog RGVmaW5lIEdQRSBjb250cm9sIG1ldGhvZCAnX0wwMicuICovCiAgICAgcHVzaF9ibG9jaygi U2NvcGUiLCAiXFxfR1BFIik7CiAgICAgcHVzaF9ibG9jaygiTWV0aG9kIiwgIl9MMDIiKTsK LSAgICBzdG10KCJSZXR1cm4iLCAiXFxfUFIuUFJTQygpIik7CisgICAgc3RtdCgiUmV0dXJu IiwgIlxcX1NCLlBSU0MoKSIpOwogICAgIHBvcF9ibG9jaygpOwogICAgIHBvcF9ibG9jaygp OwogICAgIC8qKioqIFByb2Nlc3NvciBlbmQgKioqKi8K --B_3348815367_8355688 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --B_3348815367_8355688--