xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Fix an ACPI bug
@ 2010-02-12 19:50 Liu, Jinsong
  2010-02-12 19:57 ` Liu, Jinsong
  2010-02-12 20:20 ` Keir Fraser
  0 siblings, 2 replies; 3+ messages in thread
From: Liu, Jinsong @ 2010-02-12 19:50 UTC (permalink / raw)
  To: xen-devel; +Cc: Keir Fraser

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

Fix an ACPI asl bug.

Fix an ACPI asl bug by explicitly convert PRS to buffer, otherwise PRS would be parsed as integer if less than 32/64 bits (according to ACPI 1.0 or 2.0).

Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com>

[-- Attachment #2: 01-dsdt --]
[-- Type: application/octet-stream, Size: 816 bytes --]

Fix an ACPI asl bug.

Fix an ACPI asl bug by explicitly convert PRS to buffer, otherwise PRS would be parsed as integer if less than 32/64 bits (according to ACPI 1.0 or 2.0).

Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com>

diff -r de00957fe660 tools/firmware/hvmloader/acpi/mk_dsdt.c
--- a/tools/firmware/hvmloader/acpi/mk_dsdt.c	Sat Feb 13 02:27:25 2010 +0800
+++ b/tools/firmware/hvmloader/acpi/mk_dsdt.c	Sat Feb 13 02:30:18 2010 +0800
@@ -139,7 +139,7 @@ int main(int argc, char **argv)
 
     /* Control method 'PRSC': CPU hotplug GPE handler. */
     push_block("Method", "PRSC, 0");
-    stmt("Store", "PRS, Local0");
+    stmt("Store", "ToBuffer(PRS), Local0");
     for ( cpu = 0; cpu < max_cpus; cpu++ )
     {
         /* Read a byte at a time from the PRST online-CPU bitmask. */

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] Fix an ACPI bug
  2010-02-12 19:50 [PATCH] Fix an ACPI bug Liu, Jinsong
@ 2010-02-12 19:57 ` Liu, Jinsong
  2010-02-12 20:20 ` Keir Fraser
  1 sibling, 0 replies; 3+ messages in thread
From: Liu, Jinsong @ 2010-02-12 19:57 UTC (permalink / raw)
  To: Liu, Jinsong, xen-devel; +Cc: Keir Fraser

Liu, Jinsong wrote:
> Fix an ACPI asl bug.
> 
> Fix an ACPI asl bug by explicitly convert PRS to buffer, otherwise
> PRS would be parsed as integer if less than 32/64 bits (according to
> ACPI 1.0 or 2.0).  
> 
> Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com>

Sorry, the subject would be better as 'Fix an ACPI asl code bug'.

Thanks,
Jinsong

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix an ACPI bug
  2010-02-12 19:50 [PATCH] Fix an ACPI bug Liu, Jinsong
  2010-02-12 19:57 ` Liu, Jinsong
@ 2010-02-12 20:20 ` Keir Fraser
  1 sibling, 0 replies; 3+ messages in thread
From: Keir Fraser @ 2010-02-12 20:20 UTC (permalink / raw)
  To: Liu, Jinsong, xen-devel

Thanks Jinsong!

 -- Keir

On 12/02/2010 19:50, "Liu, Jinsong" <jinsong.liu@intel.com> wrote:

> Fix an ACPI asl bug.
> 
> Fix an ACPI asl bug by explicitly convert PRS to buffer, otherwise PRS would
> be parsed as integer if less than 32/64 bits (according to ACPI 1.0 or 2.0).
> 
> Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-02-12 20:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-12 19:50 [PATCH] Fix an ACPI bug Liu, Jinsong
2010-02-12 19:57 ` Liu, Jinsong
2010-02-12 20:20 ` Keir Fraser

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).