From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Andre Przywara <andre.przywara@amd.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 2/5] [POST-4.0]: HVM NUMA guest: pass NUMA information to libxc
Date: Mon, 22 Feb 2010 11:57:49 +0000 [thread overview]
Message-ID: <C7A821BD.AE46%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <4B826545.4040802@amd.com>
On 22/02/2010 11:06, "Andre Przywara" <andre.przywara@amd.com> wrote:
>> I don't know the coding style, but you seem to have two different
>> version of it. Here you do the 'for (i= ..')
> It seems that Xen does not have a consistent coding style in this
> respect, I have seen both versions in Xen already. I usually do
> coding-style-by-copying, looking at similar nearby statements and
> applying the style to the new one (useful if you do code changes in Xen
> HV, tools, ioemu, etc.). That seemed to fail here.
>
> Keir, is there a definite rule for the "space after brace" issue?
Follow the style of the file or module you edit. The style I prefer is
followed in most 'new' (as opposed to from-Linux) files in the hypervisor
itself, like xmalloc.c, page_alloc.c, x86_emulate.c, and loads of others.
Outside the hypervisor itself, I can't be bothered to police it and some
others seem to have intransigent opinions on the right-way-to-write-code. As
long as there is consistency at least on a per-file basis, personally I can
live with whatever.
-- Keir
prev parent reply other threads:[~2010-02-22 11:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 21:54 [PATCH 2/5] [POST-4.0]: HVM NUMA guest: pass NUMA information to libxc Andre Przywara
2010-02-05 0:32 ` Konrad Rzeszutek Wilk
2010-02-22 11:06 ` Andre Przywara
2010-02-22 11:57 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C7A821BD.AE46%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=andre.przywara@amd.com \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).