From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: current not very current (vs curr_vcpu)
Date: Tue, 23 Feb 2010 21:03:04 +0000
Message-ID: <C7A9F308.B143%keir.fraser@eu.citrix.com>
References: <20100223114646.70e196ea@mantra.us.oracle.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20100223114646.70e196ea@mantra.us.oracle.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Mukesh Rathor <mukesh.rathor@oracle.com>
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 23/02/2010 19:46, "Mukesh Rathor" <mukesh.rathor@oracle.com> wrote:

> struct cpu_user_regs *regs = guest_cpu_user_regs(); <------
> 
> The cpu is clearly running idle_vcpu, so current is correctly pointing
> to idle vcpu. But guest_mode() is showing guest mode incorrectly.
> 
> I'm not much familiar with ns16550 stuff, so cant' think of a fix other
> than just setting regs to current stack pointer in ns16550_poll().
> 
> __asm__ ( "movq %%rsp,%0" : "=r" (val));
> struct cpu_user_regs *regs = val;
> 
> Let me know if you like the fix and I'll submit a patch.

Given the only thing this apparently affected was some of your own ad-hoc
debug code, do we really care about this at all? We can probably happily
just leave it.

 -- Keir