From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: current not very current (vs curr_vcpu) Date: Thu, 25 Feb 2010 08:07:55 +0000 Message-ID: References: <20100224170618.6d7c4608@mantra.us.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100224170618.6d7c4608@mantra.us.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Mukesh Rathor Cc: "Xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 25/02/2010 01:06, "Mukesh Rathor" wrote: >> Okay, see how xen-unstable:20969 works for you. > > > Yup, better. Thanks a lot. > > BTW, since debuggers only care about BUG and ASSERT, perhaps > DEBUGGER_trap_entry could be moved after BUGFRAME_warn, next time > you are in do_invalid_op(). DEBUGGER_trap_entry is done early in all trap handlers. There are DEBUGGER_trap_fatal hooks in the ASSERT and BUG paths already which can be hooked in preference. The place to express that policy is in the debugger.h header or the debugger itself. And I think it already is done correctly. -- Keir