From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH]ACPI: workaround for S3 fail in two  facs
	tables case
Date: Thu, 25 Feb 2010 10:39:22 +0000
Message-ID: <C7AC03DA.B595%keir.fraser@eu.citrix.com>
References: <4B86452C020000780003136C@vpn.id2.novell.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4B86452C020000780003136C@vpn.id2.novell.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jan Beulich <JBeulich@novell.com>, Gang Wei <gang.wei@intel.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 25/02/2010 08:38, "Jan Beulich" <JBeulich@novell.com> wrote:

>> /* Now FACS... */
>> - if (fadt->header.revision >= FADT2_REVISION_ID)
>> + if (fadt->header.revision >= FADT2_REVISION_ID && fadt->facs == 0)
>> facs_pa = fadt->Xfacs;
>> else
>> facs_pa = (uint64_t)fadt->facs;
> 
> Wouldn't that generally suppress using fadt->Xfacs, since I think in
> order to be pre-2.0-OS compatible a BIOS would not normally set
> facs to zero when Xfacs is non-zero? Or is that a requirement by the
> spec?

Good question would be: What does Linux do here?

 -- Keir