From: Keir Fraser <keir.fraser@eu.citrix.com>
To: "Wei, Gang" <gang.wei@intel.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Cc: Jan Beulich <JBeulich@novell.com>
Subject: Re: [PATCH]ACPI: workaround for S3 fail in two facs tables case
Date: Thu, 25 Feb 2010 11:58:26 +0000 [thread overview]
Message-ID: <C7AC1662.B5A7%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <E6467867A6B05E4FA831B7DF29925F5C40BBA48B@shzsmsx502.ccr.corp.intel.com>
On 25/02/2010 05:49, "Wei, Gang" <gang.wei@intel.com> wrote:
> /* Now FACS... */
> - if (fadt->header.revision >= FADT2_REVISION_ID)
> + if (fadt->header.revision >= FADT2_REVISION_ID && fadt->facs == 0)
> facs_pa = fadt->Xfacs;
> else
> facs_pa = (uint64_t)fadt->facs;
I think Linux in this case falls back to facs if Xfacs is zero, rather than
always using facs if facs is non-zero. So more like:
if (fadt->header.revisions >= FADT2_REVISION_ID && fadt->Xfacs)
...
What do you think? And I was looking at Linux 2.6.27 -- has behaviour there
chanegd since then?
-- Keir
next prev parent reply other threads:[~2010-02-25 11:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 5:49 [PATCH]ACPI: workaround for S3 fail in two facs tables case Wei, Gang
2010-02-25 8:38 ` Jan Beulich
2010-02-25 10:39 ` Keir Fraser
2010-02-26 1:43 ` Wei, Gang
2010-02-25 11:58 ` Keir Fraser [this message]
2010-02-25 13:17 ` Jan Beulich
2010-02-25 13:24 ` Keir Fraser
2010-02-25 20:57 ` Keir Fraser
2010-02-26 1:24 ` Wei, Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C7AC1662.B5A7%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=JBeulich@novell.com \
--cc=gang.wei@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).