From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Jan Beulich <JBeulich@novell.com>, Gang Wei <gang.wei@intel.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH]ACPI: workaround for S3 fail in two facs tables case
Date: Thu, 25 Feb 2010 13:24:58 +0000 [thread overview]
Message-ID: <C7AC2AAA.B5E1%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <4B86866D020000780003147F@vpn.id2.novell.com>
On 25/02/2010 13:17, "Jan Beulich" <JBeulich@novell.com> wrote:
> /*
> * Check for FACS and DSDT address mismatches. An address mismatch between
> * the 32-bit and 64-bit address fields (FIRMWARE_CTRL/X_FIRMWARE_CTRL and
> * DSDT/X_DSDT) would indicate the presence of two FACS or two DSDT tables.
> */
> if (acpi_gbl_FADT.facs &&
> (acpi_gbl_FADT.Xfacs != (u64) acpi_gbl_FADT.facs)) {
> ACPI_WARNING((AE_INFO,
> "32/64X FACS address mismatch in FADT - "
> "%8.8X/%8.8X%8.8X, using 32",
> acpi_gbl_FADT.facs,
> ACPI_FORMAT_UINT64(acpi_gbl_FADT.Xfacs)));
>
> acpi_gbl_FADT.Xfacs = (u64) acpi_gbl_FADT.facs;
> }
Okay, well I guess that is basically what Gang Wei's patch implements,
although we don't print a warning and perhaps we should.
-- Keir
next prev parent reply other threads:[~2010-02-25 13:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 5:49 [PATCH]ACPI: workaround for S3 fail in two facs tables case Wei, Gang
2010-02-25 8:38 ` Jan Beulich
2010-02-25 10:39 ` Keir Fraser
2010-02-26 1:43 ` Wei, Gang
2010-02-25 11:58 ` Keir Fraser
2010-02-25 13:17 ` Jan Beulich
2010-02-25 13:24 ` Keir Fraser [this message]
2010-02-25 20:57 ` Keir Fraser
2010-02-26 1:24 ` Wei, Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C7AC2AAA.B5E1%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=JBeulich@novell.com \
--cc=gang.wei@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).