From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH]ACPI: workaround for S3 fail in two facs tables case Date: Thu, 25 Feb 2010 20:57:35 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Wei, Gang" , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 25/02/2010 05:49, "Wei, Gang" wrote: > ACPI: workaround for S3 fail in two facs tables case > > Some legacy BIOS which support ACPI2.0+ may expose two FACS tables via both > FADT->FIRMWARE_CTRL and FADT->X_FIRMWARE_CTRL, but only lookup S3 > waking_vector in the first one. So enhance the X_FIRMWARE_CTRL selection > condition by adding FADT->FIRMWARE_CTRL == 0. > > Signed-off-by: Wei Gang I reworked the patch to warn just the same as a native Linux kernel, and applied as changeset xen-unstable:20981. Thanks, Keir