From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH][XEN] p2m cleanup: remove unused function
Date: Tue, 02 Mar 2010 18:03:34 +0000
Message-ID: <C7B30376.BA48%keir.fraser@eu.citrix.com>
References: <201003021820.52535.Christoph.Egger@amd.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <201003021820.52535.Christoph.Egger@amd.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Christoph Egger <Christoph.Egger@amd.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 02/03/2010 17:20, "Christoph Egger" <Christoph.Egger@amd.com> wrote:

> Attached patch removes gfn_to_mfn_current(). It is redundant and effectively
> unused.

Hm, well, it's unused after your patch, but used a fair bit right now. It'll
need an Ack from Tim Deegan, who's on holiday until middle of next week.

> All remaining users now use proper replacement function.
> => No functional change.
> 
> While here, silence stdvga

Is that a bug fix? Anyhow would belong in a separate properly explained
patch.

> and use page_mode_hap()
> consequently.

I see you change over to using page_mode_hap() in a few places. I wasn't
sure on the justification. If you could get rid of
arch.hvm_domain.hap_enabled entirely that might make it seem more
worthwhile. Again, it would need Ack from Tim.

 -- Keir