From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] libxc bitmap utils and vcpu-affinity Date: Tue, 23 Mar 2010 11:05:27 +0000 Message-ID: References: <4BA8A1BC0200007800036662@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4BA8A1BC0200007800036662@vpn.id2.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich , Dulloor Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 23/03/2010 10:10, "Jan Beulich" wrote: >>>> Dulloor 22.03.10 18:44 >>> >> Motivation for using xenctl_cpumask in Xen interfaces : >> - xenctl_cpumap is just 4 bytes smaller than static xenctl_cpumask for >> 128 cpus (128 would be good for quite some time). However, the new > > I don't buy this (we're already building for 256 CPUs, looking forward > to further bump this in the not too distant future), and I'm generally > opposed to introducing hard coded limits in a public interface. We should use xenctl_cpumask everywhere for specifying physical CPU bitmaps, even into guest NUMA interfaces if appropriate. I don't really care if it is a bit harder to use than a static bitmap. -- Keir