From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH] xen: move viridian defines to header
Date: Thu, 01 Apr 2010 09:50:53 +0100
Message-ID: <C7DA1CFD.F747%keir.fraser@eu.citrix.com>
References: <201004011030.59969.Christoph.Egger@amd.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <201004011030.59969.Christoph.Egger@amd.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Christoph Egger <Christoph.Egger@amd.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 01/04/2010 09:30, "Christoph Egger" <Christoph.Egger@amd.com> wrote:

> 
> Hi!
> 
> Attached patch moves viridian defines into viridian header.
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>

I don't consider this a clean up by itself. It's nicer to define things in a
.c file if they are only sued in that .c file. Also moving the MSRs out but
not other viridian-architectural defines like the MSR flag definitions and
hypercall status codes seems inconsistent.

I would consider this as part of a patch series where later patches that I
actually care about make use of this change. On its own, it gets a nack.

 -- Keir