Re: [PATCH 1/1] Compiler Warning Fix

[Keir Fraser <keir.fraser@eu.citrix.com>]

This was fixed already 7-8 months ago. Seems your development tree is a tad
out of date.

 -- Keir

On 06/04/2010 19:22, "Anthony Boorsma" <Anthony.Boorsma@dornerworks.com>
wrote:

> This patch fixes a compiler warning in the file xc_core.c. This fix is needed
> because warnings are treated as errors with the new gcc in Ubuntu 9.10.
>  
> The fix was also included in a previous submission ³[Xen-devel] [PATCH 1/1]
> Xen ARINC653 scheduler² and is now being resubmitted as a separate patch.
>  
> Anthony Boorsma
> www.DornerWorks.com <http://www.DornerWorks.com>
>  
> diff -rupN a/SW/Xen/src/tools/libxc/xc_core.c
> b/SW/Xen/src/tools/libxc/xc_core.c
> --- a/SW/Xen/src/tools/libxc/xc_core.c 2010-04-06 12:59:44.343043800 -0400
> +++ b/SW/Xen/src/tools/libxc/xc_core.c             2010-04-06
> 13:01:36.359332600 -0400
> @@ -321,7 +321,15 @@ elfnote_dump_none(void *args, dumpcore_r
>      struct xen_dumpcore_elfnote_none_desc none;
>  
>      elfnote_init(&elfnote);
> -    memset(&none, 0, sizeof(none));
> +            /*
> +            * josh holtrop <DornerWorks.com> - 2009-01-04 - avoid compilation
> problem
> +            * with warning "memset used with constant zero length parameter"
> and
> +            * warnings treated as errors with the new gcc in Ubuntu 9.10
> +            */
> +            if (sizeof(none) > 0)
> +            {
> +               memset(&none, 0, sizeof(none));
> +            }
>  
>      elfnote.descsz = sizeof(none);
>      elfnote.type = XEN_ELFNOTE_DUMPCORE_NONE;
>  
>