New release candidate for Xen 3.4.3

New release candidate for Xen 3.4.3

[Keir Fraser]

Folks,

3.4.3-rc5 is now tagged in http://xenbits.xensource.com/xen-3.4-testing.hg

I hope that this will be the final RC before the 3.4.3 release. Please test!

 Thanks,
 Keir

Re: New release candidate for Xen 3.4.3

[Bryan D. Payne]

> I hope that this will be the final RC before the 3.4.3 release. Please test!

I'm getting a build error with this RC.  I simply did a "make world"
after cloning the repository and end up with the resulting error while
building tools/ioemu-remote/i386-dm:

helper2.c: In function ‘cpu_x86_init’:
helper2.c:150: error: ‘shared_iopage_t’ has no member named ‘vcpu_ioreq’

I've build many other versions of Xen from the source without
problems, so I doubt that this is something unusual with my build
environment.  However, in debugging this I did notice that
'shared_iopage_t' is defined in ioreq.h, which has four locations
inside the build tree:

(1) dist/install/usr/include/xen/hvm/ioreq.h
(2) dist/install/lib/modules/2.6.18.8-xen/source/include/xen/interface/hvm/ioreq.h
(3) linux-2.6.18-xen.hg/include/xen/interface/hvm/ioreq.h
(4) tools/include/xen/hvm/ioreq.h

Comparing these, (1) and (4) are the same and (2) and (3) are the
same.  The definition of shared_iopage_t in (2) and (3) looks like
this:

struct shared_iopage {
    struct ioreq vcpu_ioreq[1];
};
typedef struct shared_iopage shared_iopage_t;

And the definition of shared_iopage_t in (1) and (4) looks like this:

struct shared_iopage {
    struct vcpu_iodata   vcpu_iodata[1];
};
typedef struct shared_iopage shared_iopage_t;

I'm not sure what's going on here, but it seems like it could be a bug
in the build system.  Since this is an RC, I wanted to report it and
see if anyone can comment on why this is happening.

Thanks,
bryan

Re: New release candidate for Xen 3.4.3

[Keir Fraser]

On 22/04/2010 21:24, "Bryan D. Payne" <bryan@thepaynes.cc> wrote:

>> I hope that this will be the final RC before the 3.4.3 release. Please test!
> 
> I'm getting a build error with this RC.  I simply did a "make world"
> after cloning the repository and end up with the resulting error while
> building tools/ioemu-remote/i386-dm:
> 
> helper2.c: In function Œcpu_x86_init¹:
> helper2.c:150: error: Œshared_iopage_t¹ has no member named Œvcpu_ioreq¹

You are building from the wrong qemu repository. Probably you are trying to
build from qemu-xen-unstable.git rather than qemu-xen-3.4-testing.git -- do
you perhaps override CONFIG_QEMU in your environment, or something like
that.

However I do note that the tag xen-3.4.3-rc5 that I was promised in the
qemu-xen-3.4-testing.git repo does appear to be missing. Ian?

 -- Keir

Re: New release candidate for Xen 3.4.3

[Bryan D. Payne]

> You are building from the wrong qemu repository. Probably you are trying to
> build from qemu-xen-unstable.git rather than qemu-xen-3.4-testing.git -- do
> you perhaps override CONFIG_QEMU in your environment, or something like
> that.

Just checked, there's no CONFIG_QEMU in my environment.

> However I do note that the tag xen-3.4.3-rc5 that I was promised in the
> qemu-xen-3.4-testing.git repo does appear to be missing. Ian?

Sounds like this could be the culprit.  I'll await word on this and
try testing again.

Cheers,
bryan

Re: New release candidate for Xen 3.4.3

[Keir Fraser]

On 22/04/2010 21:50, "Bryan D. Payne" <bryan@thepaynes.cc> wrote:

>> You are building from the wrong qemu repository. Probably you are trying to
>> build from qemu-xen-unstable.git rather than qemu-xen-3.4-testing.git -- do
>> you perhaps override CONFIG_QEMU in your environment, or something like
>> that.
> 
> Just checked, there's no CONFIG_QEMU in my environment.
> 
>> However I do note that the tag xen-3.4.3-rc5 that I was promised in the
>> qemu-xen-3.4-testing.git repo does appear to be missing. Ian?
> 
> Sounds like this could be the culprit.  I'll await word on this and
> try testing again.

Um, yes, I can see the rc5 tag now but the qemu tree just seems broken.
Looks like a bad merge maybe. There's a changeset dated from back in October
allegedly which references vcpu_ioreq which has never been part of the Xen
3.4 interfaces.

Ian will have to sort it and then I guess we will have to do a 3.4.3-rc6.

 Thanks,
 Keir

Re: New release candidate for Xen 3.4.3

[M A Young]

On Thu, 22 Apr 2010, Keir Fraser wrote:

> 3.4.3-rc5 is now tagged in http://xenbits.xensource.com/xen-3.4-testing.hg
>
> I hope that this will be the final RC before the 3.4.3 release. Please test!

My build fails with the errors

/home/michael/rpmbuild/BUILD/xen-3.4.3/tools/ioemu-dir/vl.c: In function 
'vcpu_sanity_check':
/home/michael/rpmbuild/BUILD/xen-3.4.3/tools/ioemu-dir/vl.c:4723: error: 
'HVM_MAX_VCPUS' undeclared (first use in this function)

 	Michael Young

Re: New release candidate for Xen 3.4.3

[Keir Fraser]

On 22/04/2010 22:40, "M A Young" <m.a.young@durham.ac.uk> wrote:

> On Thu, 22 Apr 2010, Keir Fraser wrote:
> 
>> 3.4.3-rc5 is now tagged in http://xenbits.xensource.com/xen-3.4-testing.hg
>> 
>> I hope that this will be the final RC before the 3.4.3 release. Please test!
> 
> My build fails with the errors
> 
> /home/michael/rpmbuild/BUILD/xen-3.4.3/tools/ioemu-dir/vl.c: In function
> 'vcpu_sanity_check':
> /home/michael/rpmbuild/BUILD/xen-3.4.3/tools/ioemu-dir/vl.c:4723: error:
> 'HVM_MAX_VCPUS' undeclared (first use in this function)

Yeah, the qemu tree is broken. Ian will fix but I think he's on holiday
until sometime next week. Then we'll do another 'final' rc.

 -- Keir

Re: New release candidate for Xen 3.4.3

[KUWAMURA Shin'ya]

Hi Keir,

>>>>> On Thu, 22 Apr 2010 09:51:08 +0100
>>>>> keir.fraser@eu.citrix.com(Keir Fraser)  said:
> 
> 3.4.3-rc5 is now tagged in http://xenbits.xensource.com/xen-3.4-testing.hg
> I hope that this will be the final RC before the 3.4.3 release. Please test!

Could you commit xen-unstable 20980:d9db3684f292 for ia64?
  changeset:   20980:d9db3684f292
  user:        Keir Fraser <keir.fraser@citrix.com>
  date:        Thu Feb 25 11:54:19 2010 +0000
  summary:     VT-d: Fix ia64 build for 20974:3b475d9ed6b5

Best regards,
-- 
  KUWAMURA Shin'ya

Re: New release candidate for Xen 3.4.3

[Keir Fraser]

On 28/04/2010 11:28, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote:

> Keir Fraser writes ("Re: [Xen-devel] New release candidate for Xen 3.4.3"):
>> Ian will have to sort it and then I guess we will have to do a 3.4.3-rc6.
> 
> Sorry, as you suspected I tagged the wrong revision as rc5.  I've
> renamed the tag to "xen-3.4.3-rc5-broken" in all the places where I
> could find it, and made a new tag "xen-3.4.3-rc6" in the right place.
> 
> Apologies for messing this up right before going away!

Thanks, have you tried manually adding QEMU_TAG=xen-3.4.3-rc6 into current
xen-3.4-testing tip, and made sure that a fully clean 'make world' does work
now? If that works then I'll do the new RC.

 Thanks,
 Keir

Re: New release candidate for Xen 3.4.3

[Ian Jackson]

Keir Fraser writes ("Re: [Xen-devel] New release candidate for Xen 3.4.3"):
> On 22/04/2010 21:50, "Bryan D. Payne" <bryan@thepaynes.cc> wrote:
> > Sounds like this could be the culprit.  I'll await word on this and
> > try testing again.
> 
> Um, yes, I can see the rc5 tag now but the qemu tree just seems broken.
> Looks like a bad merge maybe. There's a changeset dated from back in October
> allegedly which references vcpu_ioreq which has never been part of the Xen
> 3.4 interfaces.
> 
> Ian will have to sort it and then I guess we will have to do a 3.4.3-rc6.

Sorry about this.  I just got back and am looking to see what has
happened ...

Ian.

Re: New release candidate for Xen 3.4.3

[Ian Jackson]

Keir Fraser writes ("Re: [Xen-devel] New release candidate for Xen 3.4.3"):
> Ian will have to sort it and then I guess we will have to do a 3.4.3-rc6.

Sorry, as you suspected I tagged the wrong revision as rc5.  I've
renamed the tag to "xen-3.4.3-rc5-broken" in all the places where I
could find it, and made a new tag "xen-3.4.3-rc6" in the right place.

Apologies for messing this up right before going away!

Ian.

Re: New release candidate for Xen 3.4.3

[Ian Jackson]

Keir Fraser writes ("Re: [Xen-devel] New release candidate for Xen 3.4.3"):
> Thanks, have you tried manually adding QEMU_TAG=xen-3.4.3-rc6 into current
> xen-3.4-testing tip, and made sure that a fully clean 'make world' does work
> now? If that works then I'll do the new RC.

Yes, my test build passed (sorry about the delay, it involved building
a kernel as it always does) with the change to Config.mk below.

Ian.

diff -r 5922e6864bc9 Config.mk
--- a/Config.mk	Mon Apr 26 12:16:27 2010 +0100
+++ b/Config.mk	Wed Apr 28 14:32:13 2010 +0100
@@ -119,6 +119,7 @@
 # near the place in the Xen Makefiles where the file is used.
 
 QEMU_REMOTE=http://xenbits.xensource.com/git-http/qemu-xen-3.4-testing.git
+QEMU_TAG=xen-3.4.3-rc6
 
 # Specify which qemu-dm to use. This may be `ioemu' to use the old
 # Mercurial in-tree version, or a local directory, or a git URL.