From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] Add hypercall to mark superpages to improve performance Date: Fri, 30 Apr 2010 14:30:11 -0700 Message-ID: References: <201004301443.23350.dcm@mccr.org> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <201004301443.23350.dcm@mccr.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Dave McCracken Cc: Jeremy Fitzhardinge , Xen Developers List List-Id: xen-devel@lists.xenproject.org On 30/04/2010 12:43, "Dave McCracken" wrote: >> Secondly, I don't really believe that the mark/unmark >> hypercalls are race-free -- bearing in mind, that other mappings (superpage >> or otherwise) can be constructed or deleted in parallel on other cpus. > > I'll look into what can be done to prevent races. I suspect some races we > don't care about. I mean I think there are probably races that can result in inconsistent reference counts. I reckon I'll be able to find some when I'm back from travelling next week. Obviously, any such race would be unacceptable. -- Keir