From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH 3/3]xl: Add command description to command
	table
Date: Tue, 4 May 2010 17:20:44 +0100
Message-ID: <C80607EC.134A0%keir.fraser@eu.citrix.com>
References: <19424.18139.100478.129602@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <19424.18139.100478.129602@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Jackson <Ian.Jackson@eu.citrix.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 04/05/2010 17:10, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote:

>> +extern struct cmd_spec cmd_table[];
>> +extern int cmdtable_len;
>> +
>>  extern struct libxl_ctx ctx;
>>  extern int logfile;
> 
> This is wrong.  Use of "extern" in this way in a .c file is incorrect;
> pure predeclarations should appear only in .h files, and they should
> appear exactly once each.  That way they can't get out of step.
> 
> I'll send a patch to fix this at some point.

I fixed it before I applied it.

 -- Keir