From: Keir Fraser <keir.fraser@eu.citrix.com>
To: "Jiang, Yunhong" <yunhong.jiang@intel.com>,
Frank Van Der Linden <frank.van.der.linden@oracle.com>,
"Ke, Liping" <liping.ke@intel.com>
Cc: "Christoph@rcsinet11.oracle.com" <Christoph@rcsinet11.oracle.com>,
Egger <Christoph.Egger@amd.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"gavin.maltby@oracle.com" <gavin.maltby@oracle.com>
Subject: Re: RE: [PATCH] x86: add CMCI software injection interface
Date: Wed, 5 May 2010 10:20:37 +0100 [thread overview]
Message-ID: <C806F6F5.1355F%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <789F9655DD1B8F43B48D77C5D30659731E417C5C@shsmsx501.ccr.corp.intel.com>
On 05/05/2010 10:07, "Jiang, Yunhong" <yunhong.jiang@intel.com> wrote:
>> If going with the former option it would be good to think ahead in your
>> designs and make sure you end up adding the smallest possible number of new
>> XEN_MC_* commands. It could easily become a real mess I'm sure.
>
> "either of these"? Maybe I didn't express my idea clearly. I didn't propose
> two options. I just suggest to use a new command for this purpose. And we can
> update the version number if needed.
>
> BTW, as currently Xen already will return -EINVAL for not-support command
> (i.e. <= 5), maybe the version number update is not needed. ( the -EINVAL may
> be not good as -ENOSYS).
Oh, sorry, I thought you were expressing either-or. If you add a new command
then you do not update the version number: that would pointlessly disable
MCE on older guests.
-- Keir
next prev parent reply other threads:[~2010-05-05 9:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-28 10:06 [PATCH] x86: add CMCI software injection interface Ke, Liping
2010-05-04 13:06 ` Keir Fraser
2010-05-05 1:56 ` Ke, Liping
2010-05-05 3:52 ` Frank Van Der Linden
2010-05-05 7:11 ` Jiang, Yunhong
2010-05-05 8:54 ` Keir Fraser
2010-05-05 9:07 ` Jiang, Yunhong
2010-05-05 9:20 ` Keir Fraser [this message]
2010-05-05 9:34 ` Jiang, Yunhong
2010-06-07 8:12 ` Jiang, Yunhong
2010-05-05 7:46 ` Jan Beulich
2010-05-05 7:53 ` Christoph Egger
2010-05-05 8:09 ` Jan Beulich
2010-05-05 8:54 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C806F6F5.1355F%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=Christoph.Egger@amd.com \
--cc=Christoph@rcsinet11.oracle.com \
--cc=frank.van.der.linden@oracle.com \
--cc=gavin.maltby@oracle.com \
--cc=liping.ke@intel.com \
--cc=xen-devel@lists.xensource.com \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).