Re: one question to p2m table entry type

[Keir Fraser <keir.fraser@eu.citrix.com>]

I think you're right, and this was probably too subtle to pick up in the
initial phase of code cleanup when non-pae support was removed. I think
Tim's away for a week or two now so you may not get a definitive response
for a little while.

 -- Keir

On 05/05/2010 09:17, "Jiang, Yunhong" <yunhong.jiang@intel.com> wrote:

> Tim/Keir, I noticed that when translatiing p2m table type and p2m pte entry
> flags, there are difference handling for x86_64 and x32 like:
> 
> in p2m_type_to_flags:
> #ifdef __x86_64__
>     flags = (unsigned long)(t & 0x3fff) << 9;
> #else
>     flags = (t & 0x7UL) << 9;
> #endif
> 
> in p2m_flags_to_type:
>     /* Type is stored in the "available" bits */
> #ifdef __x86_64__
>     return (flags >> 9) & 0x3fff;
> #else
>     return (flags >> 9) & 0x7;
> 
> But since we don't support pure 32 bit xen hypervisor any more, and for 32
> PAE, we are sure have enough bit to keep these flags, why do we need these
> special handling? Are there any special reason for it?
> 
> Thanks
> --jyh
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel