From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH, v2] reduce 'd' debug key's global impact Date: Thu, 6 May 2010 10:05:48 +0100 Message-ID: References: <4BE2966B0200007800001837@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4BE2966B0200007800001837@vpn.id2.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 06/05/2010 09:14, "Jan Beulich" wrote: >>>> Keir Fraser 06.05.10 10:01 >>> >> Although I suppose the event-check vector has a cleaner interface for >> calling it and should be implemented for all architectures. If you add >> whatever new flag you need to irq_cpustat_t then it would be cheap to check, >> being a definite cache hit. I suppose each cpu would >> check-and-check-and-clear it, and then set it for the next CPU when it is >> done. That doesn't sound too bad. > > Hmm, isn't irq_cpustat_t being used mostly on the local CPU so far, > and hence introducing reasons for bouncing the cache line wouldn't > be nice? It would only get bounced when the 'd' key is pressed, right? I think we could tolerate that frequency of bounce. :-) -- Keir