From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH, v2] reduce 'd' debug key's global    impact
Date: Thu, 6 May 2010 10:37:42 +0100
Message-ID: <C8084C76.13642%keir.fraser@eu.citrix.com>
References: <4BE2A73902000078000018A0@vpn.id2.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4BE2A73902000078000018A0@vpn.id2.novell.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jan Beulich <JBeulich@novell.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 06/05/2010 10:25, "Jan Beulich" <JBeulich@novell.com> wrote:

>> Yes, most definitely. They are cheap and should be added unconditionally to
>> the handler if you go this route.
> 
> Hmm, smp_call_function_interrupt() for example also doesn't do this
> unconditionally, so I'd prefer having them only in the unlikely code
> path.

Well, it doesn't matter much either way. Whatever makes the code simpler.

 -- Keir