From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: bad interaction between boosted idle vcpus and csched's tickling?
Date: Fri, 7 May 2010 14:02:44 +0100 [thread overview]
Message-ID: <C809CE04.13A84%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <4BE4255B0200007800001C89@vpn.id2.novell.com>
On 07/05/2010 13:36, "Jan Beulich" <JBeulich@novell.com> wrote:
> Keir,
>
> isn't there a problem after the change to handle tasklets in idle vcpus
> in that {default,acpi_processor}_idle() will put the vcpu to sleep with
> boosted priority still in place, hence preventing it from being tickled
> and/or needlessly tickling other CPUs?
See the comment above tasklet_list definition in tasklet.c: we always run
through the scheduler when tasklets are added/removed. That is explicitly to
get the idle thread's priority set correctly.
I think this could be handled better though, and also in the current
approach I actually still probably don't have enough raise_softirq() calls.
:-) I will take another look and see if I can make things more obvious and
robust.
Thanks,
Keir
> Jan
>
next prev parent reply other threads:[~2010-05-07 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 12:36 bad interaction between boosted idle vcpus and csched's tickling? Jan Beulich
2010-05-07 13:02 ` Keir Fraser [this message]
2010-05-11 10:14 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C809CE04.13A84%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=JBeulich@novell.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).