From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Wei Wang2 <wei.wang2@amd.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] svm: Avoid VINTR injection during NMI shadow
Date: Fri, 7 May 2010 17:56:32 +0100 [thread overview]
Message-ID: <C80A04D0.13AC9%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <201005071641.50013.wei.wang2@amd.com>
I think the if statement should be:
if ((vmcb->general1_intercepts & GENERAL1_INTERCEPT_IRET) &&
(intack.source == hvm_intsrc_nmi))
return;
Which I think deals properly and specifically with this hang problem.
What do you think?
-- Keir
On 07/05/2010 15:41, "Wei Wang2" <wei.wang2@amd.com> wrote:
> Hi,
> I had observed that if xen injects and intercepts VINTR during NMI shadow, and
> if the xen injects NMI into guest at a very hight frequency, guest vcpu will
> hang. Attached patch avoids VINTR injection when guest is handling a NMI.
>
> Thanks,
>
> Wei
> Signed-off-by: Wei Wang <wei.wang2@amd.com>
> Reviewed-by: Wei Huang<wei.huang2@amd.com>
> --
> Legal Information:
> Advanced Micro Devices GmbH
> Karl-Hammerschmidt-Str. 34
> 85609 Dornach b. München
>
> Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
> Sitz: Dornach, Gemeinde Aschheim, Landkreis München
> Registergericht München, HRB Nr. 43632
next prev parent reply other threads:[~2010-05-07 16:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 14:41 [PATCH] svm: Avoid VINTR injection during NMI shadow Wei Wang2
2010-05-07 16:56 ` Keir Fraser [this message]
2010-05-07 17:18 ` Wei Wang2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C80A04D0.13AC9%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=wei.wang2@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).