From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] svm: Avoid VINTR injection during NMI shadow Date: Fri, 7 May 2010 17:56:32 +0100 Message-ID: References: <201005071641.50013.wei.wang2@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <201005071641.50013.wei.wang2@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Wei Wang2 , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org I think the if statement should be: if ((vmcb->general1_intercepts & GENERAL1_INTERCEPT_IRET) && (intack.source =3D=3D hvm_intsrc_nmi)) return; Which I think deals properly and specifically with this hang problem. What do you think? -- Keir On 07/05/2010 15:41, "Wei Wang2" wrote: > Hi, > I had observed that if xen injects and intercepts VINTR during NMI shadow= , and > if the xen injects NMI into guest at a very hight frequency, guest vcpu w= ill > hang. Attached patch avoids VINTR injection when guest is handling a NMI. >=20 > Thanks, >=20 > Wei > Signed-off-by: Wei Wang > Reviewed-by: Wei Huang > -- > Legal Information: > Advanced Micro Devices GmbH > Karl-Hammerschmidt-Str. 34 > 85609 Dornach b. M=FCnchen >=20 > Gesch=E4ftsf=FChrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni > Sitz: Dornach, Gemeinde Aschheim, Landkreis M=FCnchen > Registergericht M=FCnchen, HRB Nr. 43632