From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: Cpupools and pdata_alloc Date: Tue, 11 May 2010 19:41:37 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: George Dunlap , Juergen Gross Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 11/05/2010 18:25, "George Dunlap" wrote: > Kier, out of curiosity, is there a reason init_idle_domain() (and thus > schedule_init()) is called so early, before all of the cpus are up? > Is it so that adding a cpu dynamically and at boot (which needs to do > in it, add an idle vcpu, &c) all take the same codepath? Well, once secondary CPUs are fully up they are of course running their respective idle VCPUs, so we can't call schedule_init() very late. The right thing to do is dynamically allocate state as CPUs are brought online -- and potentially free that state when CPUs are taken offline. Which is pretty much the direction the code points in already. -- Keir