From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: Cpupools and pdata_alloc Date: Tue, 11 May 2010 19:55:30 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: George Dunlap Cc: Juergen Gross , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 11/05/2010 19:52, "George Dunlap" wrote: > On Tue, May 11, 2010 at 1:41 PM, Keir Fraser > wrote: >> Well, once secondary CPUs are fully up they are of course running their >> respective idle VCPUs, so we can't call schedule_init() very late. The right >> thing to do is dynamically allocate state as CPUs are brought online -- and >> potentially free that state when CPUs are taken offline. Which is pretty >> much the direction the code points in already. > > Except that it's done a little indirectly, via initializing the idle > vcpu, rather than calling something like sched_init_pcpu() when the > cpu is brought up before creating an idle vcpu for it. :-) Anyway, > maybe once I get the credit2 stuff working again, I may think about > writing a patch to clean it up a bit... mostly so that it's easier to > follow what's going on. Splitting it into an explicit separate call into the scheduling subsystem would be acceptable, I think. -- Keir