From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: Shall we clear the cpumap in
	XEN_DOMCTL_setvcpuaffinity
Date: Wed, 12 May 2010 08:43:06 +0100
Message-ID: <C8101A9A.13FD4%keir.fraser@eu.citrix.com>
References: <789F9655DD1B8F43B48D77C5D30659731E5F20AF@shsmsx501.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <789F9655DD1B8F43B48D77C5D30659731E5F20AF@shsmsx501.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Jiang, Yunhong" <yunhong.jiang@intel.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 12/05/2010 08:22, "Jiang, Yunhong" <yunhong.jiang@intel.com> wrote:

> When browse code, I noticed if the op->u.vcpuaffinity.cpumap is NULL, a random
> value of new_affinity will be passed to vcpu_set_affinity(), as in followed
> code.
> 
> I'm not sure if this is expected result. IMO, we should return -EINVAL if no
> cpu specified, as the return value at vcpu_set_affinity() for empty cpumap.

Xen-unstable:21350.

 Thanks,
 Keir

> Did I missed anything?
> 
>     case XEN_DOMCTL_getvcpuaffinity:
>     {
>         domid_t dom = op->domain;
>         struct domain *d = rcu_lock_domain_by_id(dom);
>         struct vcpu *v;
>         cpumask_t new_affinity;
> ......
>         if ( op->cmd == XEN_DOMCTL_setvcpuaffinity )
>         {
>             xenctl_cpumap_to_cpumask(  >>>>> the new_affinity is not
> initialized for if cpumap==NULL
>                 &new_affinity, &op->u.vcpuaffinity.cpumap);
>             ret = vcpu_set_affinity(v, &new_affinity);
>         }
> 
> Thanks
> --jyh