Re: (XEN) Xen BUG at amd_nonfatal.c:165 on a new amd g34 board

[Keir Fraser <keir.fraser@eu.citrix.com>]

[-- Attachment #1: Type: text/plain, Size: 836 bytes --]

On 07/05/2010 22:45, "Keir Fraser" <keir.fraser@eu.citrix.com> wrote:

> On 07/05/2010 22:10, "Luke S Crawford" <lsc@prgmr.com> wrote:
> 
>> Keir Fraser <keir.fraser@eu.citrix.com> writes:

> Ah, looks like half the MCE stuff is not even hooked up the mce boot
> parameter. Well, I expect Christoph Egger can help: he implemented a lot of
> the MCE mechanism, and especially the AMD parts.
> 
> I think the mce boot parameter should, when disabled, cause the MCE feature
> bits to be removed from Xen's copy of CPUID feature flags. That would easily
> disable all MCE logic throughout Xen.

Actually I think the attached patch should work, in conjunction with
specifying no-mce (4.0/unstable) or nomce (3.4) as a Xen boot parameter. Let
me know if it works okay for you.

I've applied the patch to xen-unstable as c/s 21360.

 -- Keir


[-- Attachment #2: 00-mce --]
[-- Type: application/octet-stream, Size: 387 bytes --]

diff -r 0079f76e906f xen/arch/x86/cpu/mcheck/non-fatal.c
--- a/xen/arch/x86/cpu/mcheck/non-fatal.c	Wed May 12 08:53:27 2010 +0100
+++ b/xen/arch/x86/cpu/mcheck/non-fatal.c	Wed May 12 09:06:37 2010 +0100
@@ -91,7 +91,7 @@
 	struct cpuinfo_x86 *c = &boot_cpu_data;
 
 	/* Check for MCE support */
-	if (!mce_available(c))
+	if (mce_disabled || !mce_available(c))
 		return -ENODEV;
 
 	/*

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel