From: Keir Fraser <keir.fraser@eu.citrix.com>
To: "Langsdorf, Mark" <mark.langsdorf@amd.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: Sixth (and final?) release candidate for Xen 3.4.3
Date: Wed, 12 May 2010 20:21:20 +0100 [thread overview]
Message-ID: <C810BE40.14148%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <C872CBF75AC4BE4093DF425DEA49BA08061FFF370A@sausexmbp02.amd.com>
On 12/05/2010 18:50, "Langsdorf, Mark" <mark.langsdorf@amd.com> wrote:
> Sometimes, on the new 6-core processors, the powernow.c
> driver call:
>
> on_selected_cpus(&cmd.mask, transition_pstate, &cmd, 0);
Since you specify '0' for the final 'wait' parameter of on_selected_cpus(),
the call can return before transition_pstate() has finished executing on all
the requested CPUs. Hence the calling function (powernow_cpufreq_target) can
exit early, and 'cmd' becomes invalid as it is allocated in the function's
stack frame.
The fix is simply to specify '1' for the final parameter of
on_selected_cpus(). I will apply the fix to all trees and also have a quick
audit that all other callers who specify '0' really mean to.
-- Keir
next prev parent reply other threads:[~2010-05-12 19:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 12:00 Sixth (and final?) release candidate for Xen 3.4.3 Keir Fraser
2010-05-05 9:50 ` M A Young
2010-05-06 14:13 ` M A Young
2010-05-06 14:26 ` Keir Fraser
2010-05-06 16:13 ` M A Young
2010-05-06 16:34 ` Keir Fraser
2010-05-07 2:03 ` Zhang, Xiantao
2010-05-07 7:10 ` Keir Fraser
2010-05-07 23:11 ` Jeremy Fitzhardinge
2010-05-08 8:05 ` Keir Fraser
2010-05-08 11:00 ` Boris Derzhavets
2010-05-08 15:14 ` Errors when loading 2.6.32.12 under Xen 4.0 on ASUS P5Q-E Boris Derzhavets
2010-05-12 17:50 ` Sixth (and final?) release candidate for Xen 3.4.3 Langsdorf, Mark
2010-05-12 19:21 ` Keir Fraser [this message]
2010-05-12 19:42 ` Langsdorf, Mark
2010-05-06 18:50 ` Jeremy Fitzhardinge
2010-05-06 19:13 ` M A Young
2010-05-06 20:17 ` Jeremy Fitzhardinge
2010-05-07 18:33 ` M A Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C810BE40.14148%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=mark.langsdorf@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).