From: Keir Fraser <keir.fraser@eu.citrix.com>
To: "Jiang, Yunhong" <yunhong.jiang@intel.com>,
Jan Beulich <JBeulich@novell.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: One question to compat model
Date: Thu, 13 May 2010 09:48:14 +0100 [thread overview]
Message-ID: <C8117B5E.14224%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <789F9655DD1B8F43B48D77C5D30659731E5F2771@shsmsx501.ccr.corp.intel.com>
On 13/05/2010 09:41, "Jiang, Yunhong" <yunhong.jiang@intel.com> wrote:
>> Whoever implemented XENPF_getidletime decided to stuff a fake xenctl_cpumap
>> struct within Xen rather than properly refactor the public headers. There's
>> no reason not to move xenctl_cpumap out into xen.h.
>
> A curios question. I checked the code, and notice that the XEN_GUEST_HANDLE_64
> is only defined for __XEN__ or __XEN_TOOLS__. I can understand it is needed
> for tools because 32bit tools can be used in 64bit dom0, but why it is
> forbidden for kernel? To avoid it be passed as hypercall parameter? Sorry for
> bothering if this is a stupid question :$
I was probably being overzealous. There's no good reason not to use
GUEST_HANDLE_64 and uint64_aligned_t outside of tools interfaces.
-- Keir
next prev parent reply other threads:[~2010-05-13 8:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 7:38 One question to compat model Jiang, Yunhong
2010-05-12 8:00 ` Jan Beulich
2010-05-12 8:15 ` Jiang, Yunhong
2010-05-12 8:31 ` Jan Beulich
2010-05-12 8:50 ` Jiang, Yunhong
2010-05-12 9:11 ` Jan Beulich
2010-05-12 9:14 ` Jiang, Yunhong
2010-05-12 9:13 ` Keir Fraser
2010-05-13 8:41 ` Jiang, Yunhong
2010-05-13 8:48 ` Keir Fraser [this message]
2010-05-13 10:00 ` Jiang, Yunhong
2010-05-13 10:04 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C8117B5E.14224%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=JBeulich@novell.com \
--cc=xen-devel@lists.xensource.com \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).