From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: One question to compat model
Date: Thu, 13 May 2010 09:48:14 +0100
Message-ID: <C8117B5E.14224%keir.fraser@eu.citrix.com>
References: <789F9655DD1B8F43B48D77C5D30659731E5F2771@shsmsx501.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <789F9655DD1B8F43B48D77C5D30659731E5F2771@shsmsx501.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Jiang, Yunhong" <yunhong.jiang@intel.com>, Jan Beulich <JBeulich@novell.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 13/05/2010 09:41, "Jiang, Yunhong" <yunhong.jiang@intel.com> wrote:

>> Whoever implemented XENPF_getidletime decided to stuff a fake xenctl_cpumap
>> struct within Xen rather than properly refactor the public headers. There's
>> no reason not to move xenctl_cpumap out into xen.h.
> 
> A curios question. I checked the code, and notice that the XEN_GUEST_HANDLE_64
> is only defined for __XEN__ or __XEN_TOOLS__. I can understand it is needed
> for tools because 32bit tools can be used in 64bit dom0, but why it is
> forbidden for kernel? To avoid it be passed as hypercall parameter? Sorry for
> bothering if this is a stupid question :$

I was probably being overzealous. There's no good reason not to use
GUEST_HANDLE_64 and uint64_aligned_t outside of tools interfaces.

 -- Keir