From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: One question to compat model
Date: Thu, 13 May 2010 11:04:38 +0100
Message-ID: <C8118D46.14254%keir.fraser@eu.citrix.com>
References: <789F9655DD1B8F43B48D77C5D30659731E5F281D@shsmsx501.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <789F9655DD1B8F43B48D77C5D30659731E5F281D@shsmsx501.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Jiang, Yunhong" <yunhong.jiang@intel.com>, Jan Beulich <JBeulich@novell.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 13/05/2010 11:00, "Jiang, Yunhong" <yunhong.jiang@intel.com> wrote:

>> I was probably being overzealous. There's no good reason not to use
>> GUEST_HANDLE_64 and uint64_aligned_t outside of tools interfaces.
> 
> Althoug not related with my current patch, but curiosly, will it avoid the
> compat model issue if we use XEN_GUEST_HANDLE_64 for hypercall, especially if
> not performance critical, like struct xen_mc_fetch? (Maybe we still need
> consider the #pragma pack optoin for the struction?)

Oh yes, it would be a *very* good idea to use these macros to avoid the need
for compat shim code at all.

 -- Keir