xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Joanna Rutkowska <joanna@invisiblethingslab.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: Does xc_map_foreign_pages() update IOMMU tables?
Date: Thu, 13 May 2010 13:00:04 +0100	[thread overview]
Message-ID: <C811A854.1428A%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <4BEBE70B.3080706@invisiblethingslab.com>

On 13/05/2010 12:48, "Joanna Rutkowska" <joanna@invisiblethingslab.com>
wrote:

> Does the xc_map_foreign_pages() update also the IOMMU/VT-d tables so
> that the mapped pages belong also to Dom0 (from the IOMMU point of view)?

Seeing as how xc_map_foreign_pages() maps pages into a particular
guest-process virtual address space, whereas IOMMU tables are a mapping from
guest-physical address space, it's clear that x_m_f_p() cannot sensibly be
having any effect on the IOMMU.

 -- Keir

> It seems like it does indeed. We use this function in Qubes GUI
> virtualization to map composition buffers from DomUs into Dom0. Then we
> use XShmPutImage() in Dom0 to display them. We've been told [1] that
> XShmPutImage() often uses DMA to copy pages to the video memory,
> especially in case of accelerated drivers. And we verified that our GUI
> works fine on VT-d systems e.g. with Intel drivers with h/w acceleration
> enabled and with iommu=pv enabled. This suggests that
> xc_map_foreign_pages() indeed must be adding mapped pages to the IOMMU
> tables for Dom0, as otherwise XShmPutImage() would not be able to
> DMA-read the contents of those pages, that originally belonged to some
> other DomUs.
> 
> Am I missing something? If not, can somebody point me to the actual code
> in Xen which does this update?
> 
> Thanks a lot!
> joanna.
> 
> [1] http://groups.google.com/group/qubes-devel/msg/9d23cd9c26127ed7
> 

  reply	other threads:[~2010-05-13 12:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-13 11:48 Does xc_map_foreign_pages() update IOMMU tables? Joanna Rutkowska
2010-05-13 12:00 ` Keir Fraser [this message]
2010-05-13 12:09   ` Joanna Rutkowska
2010-05-13 12:27     ` Keir Fraser
2010-05-13 12:39       ` Joanna Rutkowska

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C811A854.1428A%keir.fraser@eu.citrix.com \
    --to=keir.fraser@eu.citrix.com \
    --cc=joanna@invisiblethingslab.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).